[macOS] CodeQL: Simplify the toolcache version number for bundles tagged using semver #7717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are migrating to versioning the CodeQL bundle using semantic versions rather than a date-based version. This lets us simplify how we version these bundles within the toolcache.
|
/azp run macos11, macos12 |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
(gh workflows slightly not ready here yet) |
|
(now GitHub ready too) |
angelapwen
approved these changes
Jun 14, 2023
mikhailkoliada
approved these changes
Jun 14, 2023
runnerImages
added a commit
to runnerImages/runner-images
that referenced
this pull request
Jun 19, 2023
* Fix url for the Ubuntu 20 libcontainers repo key (actions#7629) * [Ubuntu] dearmor gpg key for google-cloud-sdk (actions#7627) * Correct typo from 'Delimeter' to 'Delimiter' (actions#7625) * [macOS] Add XCode 14.3.1 for macOS 13 (actions#7631) * [macOS] Update condition for automation mode (actions#7626) * README: explain -latest migration process (actions#7634) * Update azure function name (actions#7636) * [Ubuntu] Add archive.ubuntu.com to sources.list (actions#7616) * [Ubuntu] Update libssl package version (actions#7655) * [Windows] fix choco installation (actions#7657) * [Windows] fix software report for innosetup (actions#7658) * Updating readme file for ubuntu20 version 20230517.1 (actions#7644) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for ubuntu22 version 20230517.1 (actions#7645) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for win22 version 20230517.1 (actions#7647) Co-authored-by: Image generation service account <no-reply@microsoft.com> * Updating readme file for win19 version 20230517.1 (actions#7646) Co-authored-by: Image generation service account <no-reply@microsoft.com> * [macos] add cookie based installation for Xcode (actions#7666) * Updating readme file for macOS-11 version 20230516.1 (actions#7642) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for macOS-12 version 20230516.1 (actions#7641) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * set $IsLatest to false when specifying exact version (actions#7677) * Updating readme file for macos-13 version 20230524.1 (actions#7652) Co-authored-by: Image generation service account <no-reply@microsoft.com> * [windows] warmup VisualStudio for vdproj (actions#7649) it takes up to several minutes to run devenv for the first time on vdproj. * Updating readme file for ubuntu20 version 20230604.1 (actions#7673) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * [macos] Adjust hcl2 packer templates with decoding (actions#7685) * Updating readme file for ubuntu22 version 20230604.1 (actions#7674) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Fix typo (actions#7689) * [macos] add XCode 15 to MacOS 13 images (actions#7693) * Update Visual Studio VC Component versions (actions#7694) * Updating readme file for win19 version 20230606.1 (actions#7680) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for win22 version 20230606.1 (actions#7679) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Set checkout options in inage generation pipeline (actions#7708) * Update conditions for CI jobs (actions#7714) * [Ubuntu] update curl command to work with https (actions#7723) * [macOS] CodeQL: Simplify the toolcache version number for bundles tagged using semver (actions#7717) * [Windows] CodeQL: Simplify the toolcache version number for bundles tagged using semver (actions#7718) * [Linux] CodeQL: Simplify the toolcache version number for bundles tagged using semver (actions#7716) * Updating readme file for win19 version 20230612.1 (actions#7711) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for win22 version 20230612.1 (actions#7712) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for ubuntu22 version 20230611.1 (actions#7701) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Updating readme file for ubuntu20 version 20230611.1 (actions#7702) Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> * Update GenerateResourcesAndImage related documentation (actions#7738) * Cache Android SDK packages list (actions#7709) * Revert "[Windows] download MySQL from SA (actions#6769)" (actions#7732) --------- Co-authored-by: Vasilii Polikarpov <126792224+vpolikarpov-akvelon@users.noreply.github.com> Co-authored-by: Alexey-Ayupov <116575425+Alexey-Ayupov@users.noreply.github.com> Co-authored-by: Jongwoo Han <jongwooo.han@gmail.com> Co-authored-by: Erik Bershel <110455084+erik-bershel@users.noreply.github.com> Co-authored-by: Mikhail Koliada <88318005+mikhailkoliada@users.noreply.github.com> Co-authored-by: sergei-pyshnoi <121864472+sergei-pyshnoi@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Image generation service account <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com> Co-authored-by: Shamil Mubarakshin <127750046+shamil-mubarakshin@users.noreply.github.com> Co-authored-by: Sam Fox <samfoxcode@github.com> Co-authored-by: ilia-shipitsin <125650415+ilia-shipitsin@users.noreply.github.com> Co-authored-by: Grant Hutchins <github@nertzy.com> Co-authored-by: Henry Mercer <henrymercer@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Originally opened as a cross-platform PR here: #7602)
We are migrating to tagging the CodeQL bundle using semantic versions (like
codeql-bundle-v2.13.3) rather than a date-based versions (likecodeql-bundle-20230516). This lets us simplify how we version these bundles within the toolcache.Previously, we used a version number like
2.13.3-20230516to allow us to look up the version in the toolcache by either the CLI version number (2.13.3) or the bundle tag name (codeql-bundle-20230516). This PR changes how we version bundles in the toolcache to take advantage of the new bundle tag name. For bundles versioned ascodeql-bundle-v2.13.3, we can just version the bundle in the toolcache as2.13.3since the bundle tag name is derivable from the CLI version number.Related issue: https://github.com/github/codeql-core/issues/3158
Check list