Windows 2022 20230517.1 fails with Trim error

[retirem]

Description

==> azure-arm.vhd: Method invocation failed because [System.Object[]] does not contain a method named 'Trim'.
==> azure-arm.vhd: At C:\image\SoftwareReport\SoftwareReport.Tools.psm1:91 char:12
==> azure-arm.vhd: + return ($innoSetupVersion -replace "^InnoSetup").Trim()
==> azure-arm.vhd: + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm.vhd: + CategoryInfo : InvalidOperation: (:) [], ParentContainsErrorRecordException
==> azure-arm.vhd: + FullyQualifiedErrorId : MethodNotFound

Platforms affected

• Azure DevOps
• GitHub Actions - Standard Runners
• GitHub Actions - Larger Runners

Runner images affected

• Ubuntu 20.04
• Ubuntu 22.04
• macOS 11
• macOS 12
• macOS 13
• Windows Server 2019
• Windows Server 2022

Image version and build link

Windows Server 2022 20230517.1

Is it regression?

Expected behavior

Does not fail and completes the VHD generation.

Actual behavior

Fails with error.

Repro steps

Use Service Principal and create a VHD with the script.

Used packer 1.9.1

[Alexey-Ayupov]

Hello @Technomann, We faced the same issue last week and fixed it. Please update your repository and try one more time.

[retirem]

Hi @Alexey-Ayupov!

I understand, but HOW did you fix it? Is the fix included in the 20230606.1 release?

[mikhailkoliada]

@Technomann we do not guarantee that build from the release is going to be successful, if one is building the image they should always use main, that's what we do ourselves

[retirem]

@mikhailkoliada if the release is not something that is going to build successfully, then what is it? What is the purpose of creating releases if they are not working?

As suggested by @Alexey-Ayupov I tried to build from a newer git tag win22/20230606.1, but it also failed. Please see the linked issue: #7704

I try the main now without further hope, but a release should be buildable without failure.

[mikhailkoliada]

@Technomann the release is a pin point of the repository in time, idempotence can not be guaranteed here due to the images always containing the latest changes to the date of generation.

[vpolikarpov-akvelon]

Hey @Technomann. It's really impossible to have fully reproducible releases in our case. The amount of software we install to runner images is huge and we are doing our best to keep image buildable from main branch. But many things may go wrong when you use tagged release instead. For example, some software with pinned version may be unavailable already while non-pinned software may be updated in a manner that breaks our build process. Long story short we can't guarantee releases reproducibility so it's better to build from main branch always. Sorry for the inconvenience.