-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No official way to install ninja is documented #11235
Comments
Hi @marc-hb Thank you for bringing this issue to our attention. We are looking into this issue and will update you on this issue after investigating. |
Thank you for bringing this up. (Even though this shouldn't be an issue in the first place.) |
It will be rectify soon |
Hi @Toxe ,
We are closing this issue as it does not pertain to github runner images.Thanks. |
Hi @marc-hb, I would like to inform you that we are unable to add these tools in the macOS images due to the need to maintain lightweight operating system images and limited sapce. We request that you use the below code at runtime for your build. Thanks. |
Thanks but that is irrelevant.
I don't see where is the information added by this comment.
Very good point! However we would first need to know what is the recommended/approved way to install ninja on Windows (mac and Linux seem simpler and consensual). Also, closing an issue before any work has ever started is strange.
Wow, the second line is probably the most extraordinary so far. There's been a lot of disagreement on this topic but nothing like that yet. This issue is 100% about Github hosted runners; there is really zero doubt about that. Even digressions have stuck to Github hosted runners.
ninja is low-level and extremely basic, stable and lightweight. For instance, it is minuscule compared to Visual Studio which is huge and has many (interactive) parts useless on a headless runner. This has been measured and discussed many times, most recently here: #514 (comment) Anyway, this issue was NOT asking to revisit this wrong decision; there has already been 6 "wontfix" duplicates for that, see list at the top. This new issue was filed about mitigating this problem with new documentation.
Thanks, but:
|
@marc-hb It feels like no one has even read anything you have written. |
@Toxe that's a bit extreme but yeah: the huge gap between the time and effort I put versus the level of attention I got is loudly screaming "Don't bother filing issues". Well, things could be worse: at least this issue is public. We get some transparency at least. With some other services, the same would have been a ticket buried and hidden in some opaque support system. |
Description
This is a documentation gap; there is no specific category for that so filing as a "bug".
As detailed in #514 (comment) and many others, ninja is probably the most popular tool for building C/C++. It's also used outside C/C++ Unsurprisingly, including
ninja
in the default image has been requested many times over the years:This has been rejected every time. One of the answers given practically every time: "it's easy to install at run time".
Because
ninja
is the top C/C++ build tool, how to install it should be in the official documentation.https://docs.github.com/en/search?query=ninja
The official documentation should either:
As of now, installing ninja requires searching closed issues for scattered, conflicting and out of date advice. Random tips to install ninja on Windows vary (either vcpkg that comes and goes, unreliable choco, other?), mac recommendations are very slow (brew) and Linux samples miss the important and non-obvious "apt-get update" pre-requirement #2924
From #8348 (comment)
I don't think it is "extremely" easy, see above. Especially not on Windows. But if it truly is, then documenting this will be too.
cc: @erik-bershel, @Darleev, @alepauly, @miketimeofeev, @maxim-lobanov, @dibir-magomedsaygitov
Platforms affected
Runner images affected
Image version and build link
This is a documentation gap; there was no category for that.
Is it regression?
No
Expected behavior
https://docs.github.com/en/search?query=ninja shows something
Actual behavior
https://docs.github.com/en/search?query=ninja shows nothing
Repro steps
https://docs.github.com/en/search?query=ninja
The text was updated successfully, but these errors were encountered: