Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout@v2 use Git branch --show-current which requires git 2.22.0 #121

Closed
TingluoHuang opened this issue Dec 22, 2019 · 0 comments · Fixed by #128
Closed

Checkout@v2 use Git branch --show-current which requires git 2.22.0 #121

TingluoHuang opened this issue Dec 22, 2019 · 0 comments · Fixed by #128
Assignees
@ericsciple

Comments

@TingluoHuang
Copy link
Member

The v2 checkout uses git branch --show-current at https://github.com/actions/checkout/blob/master/src/git-command-manager.ts#L177

The --show-current was introduced in git 2.22.0 but the checkout@v2 only requires 2.18.0, when using checkout@v2 in a self-hosted runner, you will get an error about the --show-current option.

"H:\Program Files\Git\cmd\git.exe" branch --show-current
##[error]error: unknown option `show-current'

Seems like we need to bump the min required git version?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsciple ericsciple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix issue checking detached when git less than 2.22 actions/checkout
2 participants
@TingluoHuang @ericsciple