Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.4.0 and weak dependency on moment? #7

Open
mizzao opened this issue Jul 16, 2015 · 7 comments
Open

Update to 0.4.0 and weak dependency on moment? #7

mizzao opened this issue Jul 16, 2015 · 7 comments

Comments

@mizzao
Copy link

mizzao commented Jul 16, 2015

Hey @acreeger, do you still use this package? If so, and since there is no official moment-timezone yet for Meteor, maybe we could bump the version and add a weak dep on momentjs:moment (removing the dep on mrt:moment.)

@dandv what do you think about making an official timezone package as well?

@aldeed
Copy link

aldeed commented Jul 21, 2015

👍

@aldeed
Copy link

aldeed commented Jul 21, 2015

I published an updated version of mrt:moment-timezone as aldeed:moment-timezone for now. Would rather see it moved to momentjs:timezone.

@mizzao
Copy link
Author

mizzao commented Jul 21, 2015

I'm confused. Where is the repo for that?

I do see that you published a v0.4.0 but I don't see that on any branch of https://github.com/aldeed/meteor-moment-timezone

@aldeed
Copy link

aldeed commented Jul 21, 2015

@mizzao Sorry, neglected to push. It's on github now.

@abernix
Copy link

abernix commented Sep 21, 2015

👍 @acreeger, any chance of making this happen? Would be a nice clean-up for this project.

@acreeger
Copy link
Owner

I'm no longer tracking Meteor developments, but if someone does a PR then I can merge and publish it...

@abernix
Copy link

abernix commented Sep 21, 2015

Cool, thanks for the update. In that case, it might be best if we don't update this package so it remains stable for the people who already use it and then move this code into momentjs:timezone as the moment/moment-timezone#178 ticket discusses. I think a lot of people have already started using aldeed:moment-timezone so if we're going to make a change, might as well make it the right one and get the official MomentJS repo to take care of it.

I'll look into making this happen, hopefully some time this week and let you know what, if anything, we need from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants