AcquiaDrupalStrict does not sniff install files

[swichers]

Create a minimal.php file with the following contents:

<?php

function minimal_example() {

}

Run ./vendor/bin/phpcs --standard=AcquiaDrupalStrict minimal.php

Output:

--------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
 3 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

Rename minimal.php to minimal.install

Run ./vendor/bin/phpcs --standard=AcquiaDrupalStrict minimal.install

Output:

No output

Run ./vendor/bin/phpcs --standard=Drupal minimal.install

Output:

------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
 3 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

I suspect this issue exists for all non-standard PHP_CodeSniffer file extensions, but I only verified install files.

Having <arg name="extensions" value="inc,install,module,php,profile,test,theme,yml"/> in my own phpcs.xml.dist file does not alter the behavior. Including <rule ref="Drupal" /> prior to <rule ref="AcquiaDrupalStrict" /> does wind up sniffing install files.

[TravisCarden]

Thanks for this report, @swichers. I don't immediately perceive the cause of this. I'll look into it as soon as I can.

[TravisCarden]

I haven't been able to identify the problem yet. I've reached out for help upstream: squizlabs/PHP_CodeSniffer#2602

[TravisCarden]

I've identified the problem. It seems indeed to be a bug in PHP_CodeSniffer. I've worked around it in 3ea1e57 and released it in v0.4.0. Thanks again for reporting this, @swichers!