Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema updates get run on new installs #909

Closed
danepowell opened this issue Jan 4, 2017 · 2 comments
Closed

Schema updates get run on new installs #909

danepowell opened this issue Jan 4, 2017 · 2 comments
Labels
Bug Something isn't working

Comments

@danepowell
Copy link
Contributor

BLT assumes that if a schema_version file does not exist, then you must be updating from a pre-versioned BLT install: https://github.com/acquia/blt/blob/8.x/phing/tasks/properties.xml#L30

But new installs also have no schema_version file, so all available schema updates also run on new installs. I'm not sure if this is necessarily harmful, but it is definitely unnecessary.

I think the easiest solution would be for the install process to automatically generate a "fresh" schema_version file so updates don't get run... @grasmash thoughts?
@grasmash
Copy link
Contributor

grasmash commented Jan 4, 2017

This will be resolved by #907

@grasmash grasmash added the Bug Something isn't working label Jan 5, 2017
@grasmash
Copy link
Contributor

grasmash commented Jan 5, 2017

Addressed in #913

@grasmash grasmash closed this as completed Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grasmash @danepowell