Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The local:refresh task overwrites local.settings.php #248

Closed
sarahjean opened this issue Aug 1, 2016 · 2 comments
Closed

The local:refresh task overwrites local.settings.php #248

sarahjean opened this issue Aug 1, 2016 · 2 comments
Labels
Bug Something isn't working

Comments

@sarahjean
Copy link

local.* files are usually meant to override what is set up in version control. Running local:refresh currently overwrites what is in local.settings.php with the contents of default.local.settings.php so any local overrides will be lost. It seemed to me that the purpose of local:refresh was to be run frequently during development to enable testing pull requests against an up to date local site that matches test. I think any copying from default.local.settings.php should be confined to an initial setup task and not something that is meant to be rerun again to avoid frustrating developers who might lose local settings unexpectedly.

@grasmash
Copy link
Contributor

grasmash commented Aug 3, 2016

This has been addressed by #210

@grasmash grasmash closed this as completed Aug 3, 2016
@sarahjean
Copy link
Author

👍

@grasmash grasmash added the Bug Something isn't working label Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants