Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Split upgrade to Beta 4 could be tricky #1199

Closed
geerlingguy opened this issue Mar 15, 2017 · 7 comments
Closed

Config Split upgrade to Beta 4 could be tricky #1199

geerlingguy opened this issue Mar 15, 2017 · 7 comments
Labels
Support A support request

Comments

@geerlingguy
Copy link
Contributor

geerlingguy commented Mar 15, 2017

When I run this command:

blt local:refresh

I get the following output:

blt > local:update:
blt > setup:update:
The following directory will be used to merge config into the active storage:
../config/local
Import the configuration? (y/n): y
exception 'Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException' with message 'You have      [error]
requested a non-existent service "config_split.cli".' in
/var/www/project/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php:157
Stack trace:
#0 /var/www/project/docroot/core/lib/Drupal.php(158):
Drupal\Component\DependencyInjection\Container->get('config_split.cl...')
#1 /var/www/project/docroot/modules/contrib/config_split/config_split.drush.inc(123):
Drupal::service('config_split.cl...')
#2 [internal function]: drush_config_split_import('local')
#3 /var/www/project/vendor/drush/drush/includes/command.inc(422): call_user_func_array('drush_config_sp...',
...

Basically, I have a site that's been using Config Split to manage configuration between environments. I'm trying to upgrade BLT, and as part of the final step (composer update), Config Split is upgraded to the beta4 release, which includes a new dependency on Config Filter.

This is all well and good, but it seems there's an issue with Drush 8.1.10 and Config Split, possibly (or maybe something else, not sure yet). We might need to update the docs and code slightly, too, to support the new structure. I'm still investigating, will keep posting notes here.

@geerlingguy
Copy link
Contributor Author

Ah, looks like a bug in the module (but it says it was fixed...): Dependancy on non-existent service.

@geerlingguy
Copy link
Contributor Author

Locally, after I run blt local:refresh and let it fail, if I then run:

drush @beagov.local en -y config_filter
drush @beagov.local csim -y local

...then it works. So it seems it could be an order of operations issue—I did enable the module and stick it in my core config... but it looks like I might need to make sure updb is run prior to csim?

@geerlingguy
Copy link
Contributor Author

It looks like that was the issue—I changed the order in my overridden setup:update command so it runs updb first, then config-split-import. This seems to work okay.

@geerlingguy
Copy link
Contributor Author

This definitely impacts #1102, though—Config Split now uses commands like csim [split] instead of csim --split=[split].

@grasmash
Copy link
Contributor

Thanks @geerlingguy. Will take this into consideration for #1102.

@grasmash grasmash added the Support A support request label Mar 16, 2017
@geerlingguy
Copy link
Contributor Author

I also ran into Split no longer merges from default.

@arknoll
Copy link
Contributor

arknoll commented Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support A support request
Projects
None yet
Development

No branches or pull requests

3 participants