Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cook off bug - vehicle never explodes, and cook off flame occurs multiple times. #9743

Closed
Vereenn opened this issue Jan 17, 2024 · 12 comments · Fixed by #9758
Closed

Cook off bug - vehicle never explodes, and cook off flame occurs multiple times. #9743

Vereenn opened this issue Jan 17, 2024 · 12 comments · Fixed by #9758

Comments

@Vereenn
Copy link

Vereenn commented Jan 17, 2024

Mods:

  • Arma 3: `2.14 profiling
  • CBA: `3.16.1
  • ACE3: `3.16.2 stable

Description:
Cook off doesn't seem to be working properly. It occurs continuously with short breaks, and sometimes it also looks bugged like some kind of star pattern. The vehicle will never explode even though the "destroy vehicles after cook off" is selected. Advanced vehicle damage is on as well.

Steps to reproduce:
Launch Arma, with ace
Spawn vehicle using zeus, attempt to destroy it via various means.

Expected behavior:
I expected the vehicle to cook off and then explode.

Where did the issue occur?

  • Dedicated / Self-Hosted Multiplayer / Singleplayer / Editor (Singleplayer) / Editor (Multiplayer) - the issue occurs in every of these cases.

Log Files:
https://pastebin.com/7QJe48ie

Additional context:
None.

Screenshots:
image
image

@johnb432
Copy link
Contributor

johnb432 commented Jan 17, 2024

It occurs continuously with short breaks

That's intended. Star pattern is also intended, but it shouldn't remain (those effects should last 20 seconds max if I recall correctly).


Can you post all CBA settings from cookoff and advanced vehicle damage?


2:45:12 [ACE] (cookoff) WARNING: no valid selection for cookoff found. O_APC_Tracked_02_cannon_F

That might be the issue, but need the settings to understand further.

@Vereenn
Copy link
Author

Vereenn commented Jan 17, 2024

It occurs continuously with short breaks

That's intended. Star pattern is also intended, but it shouldn't remain (those effects should last 20 seconds max if I recall correctly).

Can you post all CBA settings from cookoff and advanced vehicle damage?

2:45:12 [ACE] (cookoff) WARNING: no valid selection for cookoff found. O_APC_Tracked_02_cannon_F

That might be the issue, but need the settings to understand further.

image
image

@johnb432
Copy link
Contributor

It can take a while for a vehicle to fully burn through its ammo and have finished its cook-off, only then does the vehicle get destroyed. How long did you wait?

sometimes it also looks bugged like some kind of star pattern

Can you elaborate on this further? How did it stay stuck - frozen flames or did the flames never stop?

@Vereenn
Copy link
Author

Vereenn commented Jan 17, 2024

It can take a while for a vehicle to fully burn through its ammo and have finished its cook-off, only then does the vehicle get destroyed. How long did you wait?

I left the game running in the background for about 10 minutes and it was still cooking off. I remember that some ACE versions ago it used to cook off once then explode.

Can you elaborate on this further? How did it stay stuck - frozen flames or did the flames never stop?

The flames stop for a brief moment, and then the cook off flame begins again.

@johnb432
Copy link
Contributor

The flames stop for a brief moment, and then the cook off flame begins again.

That's expected behaviour, from a code point of view.

I suggest playing with the settings to get something you like.

@Vereenn
Copy link
Author

Vereenn commented Jan 17, 2024

Alright, but is the vehicle not exploding ever also expected behaviour? Because this way it is impossible to completely destroy vehicles with advanced vehicle damage setting on. It will keep cooking off, even though there's no ammo inside at all, and therefore the setting "destroy vehicles after cook off" is meaningless.

@johnb432
Copy link
Contributor

It will keep cooking off, even though there's no ammo inside at all

In the code, that isn't what governs the destruction of a vehicle. If you give it enough time, it will destroy the vehicle after the cook-off has finished. For me it was 2-3 minutes.

I would advise turning off advanced vehicle damage, if you want to avoid such behaviour.

@Vereenn
Copy link
Author

Vereenn commented Jan 17, 2024

That's what I thought but the dumb vanilla "explode after receiving x damage" is even worse. I wouldn't have any problems with cook off if it wasn't for the fact that it takes so long.

In the code, that isn't what governs the destruction of a vehicle. If you give it enough time, it will destroy the vehicle after the cook-off has finished. For me it was 2-3 minutes.

What governs the destruction of vehicle then?
Now that I think about it, is it possible at all to one shot explode vehicle with cook off and advanced vehicle damage enabled?

@johnb432
Copy link
Contributor

Now that I think about it, is it possible at all to one shot explode vehicle with cook off and advanced vehicle damage enabled?

Yes, if you do enough damage in one hit, see:

if (_newDamage >= 15) exitWith {

or an engine hit, see:

if ([_vehicle, _chanceToDetonate, _currentVehicleAmmo, _explosiveAmmoCount, _nonExplosiveAmmoCount, _injurer] call FUNC(handleDetonation)) exitWith {


What governs the destruction of vehicle then?

The intensity of the cook-off, see:

_vehicle setVariable [QGVAR(intensity), _intensity];

That's determined in https://github.com/acemod/ACE3/blob/master/addons/vehicle_damage/functions/fnc_processHit.sqf.
There are 4 hitpoints that cause cook-off when hit: Engine, hull, turret and fuel. The cook-off intensity in each case depends on different aspects (e..g. fuel depends on how much fuel is left, turret depends on how much explosive ammo is left).

@johnb432
Copy link
Contributor

Because this isn't a bug, this is now closed.

@johnb432 johnb432 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
@acknowledge14
Copy link

Could we expect more (CBA) settings for Advanced vehicle damage / cookoff, so that we can more easily made heavy armors totally destroyed with multiple fatal hits?

@johnb432
Copy link
Contributor

Could we expect more (CBA) settings for Advanced vehicle damage / cookoff, so that we can more easily made heavy armors totally destroyed with multiple fatal hits?

Please make feature requests on #3594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants