Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.54 Replace local keyword with private #2755

Closed
PabstMirror opened this issue Oct 16, 2015 · 3 comments
Closed

1.54 Replace local keyword with private #2755

PabstMirror opened this issue Oct 16, 2015 · 3 comments
Labels
kind/task
Milestone
3.4.0

Comments

@PabstMirror
Copy link
Contributor

^([\s]*)local([\s]+_[\w\d]+[\s]*=.*)$

\1private\2

ref https://forums.bistudio.com/topic/140837-development-branch-changelog/page-32#entry2926039
@PabstMirror PabstMirror added this to the Ongoing milestone Oct 16, 2015
@jonpas
Copy link
Member

jonpas commented Oct 16, 2015

Has anyone tested if local still works on dev-branch? I'd hope BI would leave as well for backwards compatibility.

@jonpas jonpas mentioned this issue Oct 16, 2015
Closed
@VKing6
Copy link
Member

VKing6 commented Oct 21, 2015

Has anyone tested if local still works on dev-branch? I'd hope BI would leave as well for backwards compatibility.

Appears to not work. Everything needs to be replaced.

@PabstMirror PabstMirror mentioned this issue Nov 10, 2015
Merged
@commy2 commy2 mentioned this issue Nov 17, 2015
Merged
@nicolasbadano
Copy link
Contributor

This issue should probably be closed.

@commy2 commy2 closed this as completed Nov 17, 2015
@commy2 commy2 modified the milestones: 3.4.0, Ongoing Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
5 participants
@VKing6 @commy2 @nicolasbadano @jonpas @PabstMirror