Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interface to insert a thematic break #24

Closed
dselman opened this issue Feb 23, 2019 · 6 comments · Fixed by #149
Closed

User interface to insert a thematic break #24

dselman opened this issue Feb 23, 2019 · 6 comments · Fixed by #149

Comments

@dselman
Copy link
Contributor

dselman commented Feb 23, 2019

Markdown supports the concept of a thematic break which markdown-pdf interprets as a page break (--- in markdown). Having a toolbar item to insert a thematic break in the markdown editor would allow users to control where page breaks occur in PDFs that are generated from the contents of the editor.

The thematic break should be rendered in Slate to indicate that a page break will occur. E.g.

---- page break ---- 

Or similar.

In CommonMark this is represented by an org.accordproject.commonmark.ThematicBreak node. See:
https://models.accordproject.org/markdown/commonmark@0.2.0.html

@jolanglinais
Copy link
Member

Hacktoberfest:

This issue can provide for multiple pull requests.

@Innovator007
Copy link

Can you describe more about this issue @dselman.

@jolanglinais
Copy link
Member

I think this is about having a button in the formatting toolbar to insert a horizontal rule into the markdown (---).

@waahhhh
Copy link

waahhhh commented Oct 19, 2019

On it!

@waahhhh
Copy link

waahhhh commented Oct 20, 2019

I have created a draft because I am unsure whether removing the horizontal line (backspace) in the method "handleBackspace" does not work or there is a bug in Slate.

@jolanglinais jolanglinais transferred this issue from accordproject/markdown-editor May 13, 2020
@dselman dselman added Good First Issue :octocat: Good for newcomers Help Wanted 🆘 Extra attention is needed labels Jul 7, 2020
@dselman
Copy link
Contributor Author

dselman commented Jul 7, 2020

markdown-pdf inserts a page break for thematic breaks in markdown, so this would allow people to have some control over pagination.

@dselman dselman changed the title User interface to insert a horizontal rule User interface to insert a thematic break Jul 7, 2020
@jolanglinais jolanglinais self-assigned this Jul 9, 2020
@jolanglinais jolanglinais added Good First Issue (Taken) and removed Good First Issue :octocat: Good for newcomers labels Jul 9, 2020
@jolanglinais jolanglinais added this to the Page Break milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment