Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Storybook packaged as a dependency #376

Closed
dselman opened this issue Apr 12, 2020 · 3 comments
Closed

Storybook packaged as a dependency #376

dselman opened this issue Apr 12, 2020 · 3 comments
Labels
Difficulty: Starter Good First Issue :octocat: Good for newcomers Type: Discussion 🗣

Comments

@dselman
Copy link
Collaborator

dselman commented Apr 12, 2020

https://github.com/accordproject/cicero-ui/blob/master/package.json#L28

Should story book be a dependency? How does this impact bundle size?
@arteevraina
Copy link
Contributor

@dselman I would like to work on this.

@jolanglinais
Copy link
Member

This ties in with #358 and #315, @98lenvi is working on it.

@DianaLease
Copy link
Member

DianaLease commented Apr 13, 2020 •
edited
Loading

@98lenvi I would check out the install docs here: https://storybook.js.org/docs/guides/guide-react/#step-1-add-dependencies

Looks like it can be a dev dependency.

@98lenvi 98lenvi mentioned this issue Apr 13, 2020
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Starter Good First Issue :octocat: Good for newcomers Type: Discussion 🗣
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dselman @DianaLease @jolanglinais @arteevraina