Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to extract part of the code to a standalone package #85

Closed
asok opened this issue Nov 1, 2018 · 2 comments
Closed

Possibility to extract part of the code to a standalone package #85

asok opened this issue Nov 1, 2018 · 2 comments

Comments

@asok
Copy link

asok commented Nov 1, 2018

Hi, lately I was looking into possibility to allow displaying remote images in markdown-mode, jrblevin/markdown-mode#316.
I see that the function org-download--image/url-retrieve does already what I was trying to code. Have you ever thought about extracting part of the code that downloads a remote files to a separate package?

@abo-abo
Copy link
Owner

abo-abo commented Jan 17, 2019

I don't think it's worthwhile to extract here: url.el does all the heavy lifting, I just have a small wrapper.

You could depend on org-download, if you don't mind bringing in org as a dependency.

@asok
Copy link
Author

asok commented Jan 17, 2019

Thanks for addressing that. In the meantime markdown-mode added the support for downloading images jrblevin/markdown-mode#378
So for me this issue is closed.

@asok asok closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants