authCallback bug, test coverage & additional type support

[mattheworiordan]

authCallback currently has no test coverage in the library, we need to add some.

Additionally, we need to add support for the callback to return:

• a token string
• a TokenDetails object
• a TokenRequest object

Based on the docs at

ably-js/common/lib/client/auth.js

Lines 155 to 156 in 1c8dd8f

	* - authCallback: (optional) a javascript callback to be used, passing a set of token
	* request params, to get a signed token request.

, I assume only a TokenRequest is supported.

See http://www.rubydoc.info/gems/ably/0.8.2/Ably%2FAuth%3Ainitialize as an example (under auth_callback),.

In our spec as well, we specify When authCallback option is set, it will execute the callback and will expect either a token string, a TokenDetails object or a TokenRequest object which will in turn be used to request a token from Ably.

[mattheworiordan]

I also don't think authCallback works when providing it with a valid signed TokenRequest.

See https://jsbin.ably.io/anadag/3/edit. The error is:

Ably: Auth.requestToken(): token request signing call returned error; err = {"keyName":"xVLyHw.koPkRA","timestamp":1437742607739,"nonce":"3114621597342193","mac":"O33fBmGloowPfOt7PKFpfZ5pspAna3ievCJCF6/qnB8="}
ably.min.js:formatted:1826 Ably: ConnectionManager.connectImpl(): Connection attempt failed with error; err = [c; statusCode=401; code=40170]

[paddybyers]

@SimonWoolf : are you ok to have a look at this please?

[SimonWoolf]

All three methods are supported already, see

ably-js/common/lib/client/auth.js

Lines 280 to 288 in 1c8dd8f

	/* the response from the callback might be a token string, a signed request or a token details */
	if(typeof(tokenRequestOrDetails) === 'string') {
	callback(null, {token: tokenRequestOrDetails});
	return;
	}
	if('issued' in tokenRequestOrDetails) {
	callback(null, tokenRequestOrDetails);
	return;
	}

. PR #80 adds a quick test for each and updates the docstring. Re second comment, see #73 (comment)