Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for an invalid token from the authUrl or callback #56

Closed
mattheworiordan opened this issue Jun 26, 2015 · 4 comments
Closed

Better error message for an invalid token from the authUrl or callback #56

mattheworiordan opened this issue Jun 26, 2015 · 4 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@mattheworiordan
Copy link
Member

When the authUrl requests a token from a URL that returns a token string instead of JSON, yet the client thinks it is JSON, a very unhelpful error message is shown:

Ably: EventEmitter.emit(): Unexpected listener exception: SyntaxError: Unexpected token L; stack = SyntaxError: Unexpected token L
@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Jun 26, 2015
@paddybyers
Copy link
Member

This is resolved: 93b658b

@mattheworiordan
Copy link
Member Author

Thanks. Moving forwards, I'll try and create a JSBin for each of these issues so that we can test the fixes as well.

@paddybyers
Copy link
Member

There is a test: https://github.com/ably/realtime/commit/b7ef95d

@paddybyers
Copy link
Member

Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @paddybyers