Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparse stat support #22

Closed
mattheworiordan opened this issue Mar 26, 2015 · 3 comments
Closed

Sparse stat support #22

mattheworiordan opened this issue Mar 26, 2015 · 3 comments
Assignees
@paddybyers
Labels
enhancement New feature or improved functionality.

Comments

@mattheworiordan
Copy link
Member

Can you confirm if JSON values will default to zero now that we will roll out sparse stat support?

Whilst sparse stats for efficiency between client & server is probably the right option, I am not sure the client libraries should be providing empty objects to stat queries so do prefer either a complete JSON object with zero values for each stat, or a more typed approach like we have done in https://github.com/ably/ably-java/blob/master/src/io/ably/types/Stats.java or ably/ably-ruby@cec0349
@mattheworiordan mattheworiordan added the enhancement New feature or improved functionality. label Mar 26, 2015
@paddybyers
Copy link
Member

a more typed approach

See: 16c1515

@paddybyers
Copy link
Member

Resolved

@mattheworiordan
Copy link
Member Author

Nice, this looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddybyers paddybyers

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @paddybyers