Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React-Hooks] usePresence unsubscribes all listeners on unmount and run Presence.leave even if connection has been terminated #1610

Closed
ttypic opened this issue Feb 6, 2024 · 1 comment · Fixed by #1611
Closed

[React-Hooks] usePresence unsubscribes all listeners on unmount and run Presence.leave even if connection has been terminated #1610

ttypic opened this issue Feb 6, 2024 · 1 comment · Fixed by #1611
Assignees
@ttypic

Comments

@ttypic
Copy link
Collaborator

ttypic commented Feb 6, 2024

We need to fix usePresence hook behavior. Currently,

  • it unsubscribes all listeners on unmount, not just the ones it attached inside the hook.
  • run Presence.leave even if connection has been terminated it leads to errors when client has been closed
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Feb 6, 2024

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-4078

@ttypic ttypic mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttypic ttypic

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK-4078] fix: usePresence clean up functions ably/ably-js
1 participant
@ttypic