Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corner radius changing #75

Closed
XFactorus opened this issue Jul 1, 2020 · 2 comments · Fixed by #76
Closed

Corner radius changing #75

XFactorus opened this issue Jul 1, 2020 · 2 comments · Fixed by #76
Assignees
@aataraxiaa
Labels
enhancement

Comments

@XFactorus
Copy link

Hello,

Can we please make "cornerRadius" property in "ScalingCarouselCell" class public?

It will allow updating view for user needs and design and should not break anything.

The fix is pretty easy in ScalingCarouselCell.swift:

open var cornerRadius: CGFloat = 20.0
...
mainView.layer.cornerRadius = 20

Thanks!
@aataraxiaa aataraxiaa self-assigned this Jul 3, 2020
@aataraxiaa aataraxiaa linked a pull request Jul 3, 2020 that will close this issue
Add cornerRadius property to ScalingCarouselCell #76
Merged
@aataraxiaa
Copy link
Owner

@XFactorus PR opened and linked

@XFactorus
Copy link
Author

Sorry for the long reply.

Looks great, thanks

@aataraxiaa aataraxiaa reopened this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aataraxiaa aataraxiaa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cornerRadius property to ScalingCarouselCell aataraxiaa/ScalingCarousel
2 participants
@aataraxiaa @XFactorus