Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valet new with dbprefix option does not work for Bedrock installs #32

Closed
cyrilkas opened this issue May 14, 2018 · 2 comments
Closed

valet new with dbprefix option does not work for Bedrock installs #32

cyrilkas opened this issue May 14, 2018 · 2 comments
Labels

Comments

@cyrilkas
Copy link

cyrilkas commented May 14, 2018

When I create a Bedrock project with the command wp valet new my-project --dbprefix=mywp_ --project=bedrock my tables are still with default wp_ prefix.
Any clues ?

@aaemnnosttv
Copy link
Owner

Hey, thanks for bringing this to my attention. This currently isn't implemented for Bedrock installs. The valet command translates DB configuration into values in the .env file which we generate from the .env.example which comes with the project. The optional DB_PREFIX is actually a more recent addition to the example file so I think it just wasn't there when support for Bedrock was originally added.

Should have a fix for this one soonish, but you're welcome to try your hand at a PR too :)

@aaemnnosttv aaemnnosttv changed the title DBPREFIX option is non-operational valet new with dbprefix option does not work for Bedrock installs May 15, 2018
@cyrilkas
Copy link
Author

Hi ! Thanks for your reply.
I've created a commit (my first!) change to BedrockInstaller. It's works !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants