Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of potential changes to FineRouter #3

Open
aadamsx opened this issue Sep 30, 2016 · 2 comments
Open

List of potential changes to FineRouter #3

aadamsx opened this issue Sep 30, 2016 · 2 comments

Comments

@aadamsx
Copy link
Owner

aadamsx commented Sep 30, 2016

A list of some ideas on what we could change in FineRouter to make it better, keep the good parts on move forward.

Please write only ideas. If you want to discuss details of an idea implementation, process, roadmap just open a ticket for that particular idea.

What are your ideas? What would you like to improve in FineRouter?

@mattmacpherson
Copy link

mattmacpherson commented Jan 7, 2017

FineRouter.go() and FineRouter.redirect() are both idempotent. If you want to route from domain.com/posts/1234 to domain.com/posts/5678 the URL will update but no redirect will take place. I'm pretty sure the only way to solve this is to do something like:

FineRouter.go('/posts/' + postId)
location.reload()

I would like to propose adding FineRouter.forceGo() to the API. Basically just a version of FineRouter.go() that isn't idempotent.

@aadamsx
Copy link
Owner Author

aadamsx commented Jan 7, 2017

Submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants