Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release(tests): update dry-run release commands #8298

Merged
merged 1 commit into from
Feb 22, 2024
Merged

release(tests): update dry-run release commands #8298

merged 1 commit into from
Feb 22, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We have some missing commands for new crates in the dry run release commands in the CI and in the release drafter template.

Close #8199

Solution

  • Add extra commands to release drafter and workflow script.
  • Unfortunately, this adds an extra step to the release process. We need to manually increase the versions in the workflow.

Review

Anyone can review but i think @upbqdn should take a look as he will be doing the next release. Also @gustavovalverde might want to take a look, will be great to find an easier way to do it.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added A-devops Area: Pipelines, CI/CD and Dockerfiles A-release Area: Zebra releases and release management P-Medium ⚡ labels Feb 20, 2024
@oxarbitrage oxarbitrage requested review from a team as code owners February 20, 2024 20:05
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team February 20, 2024 20:05
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 20, 2024
@upbqdn upbqdn self-requested a review February 21, 2024 11:37
mergify bot added a commit that referenced this pull request Feb 22, 2024
@mergify
Merge of #8298
106481c
@mergify mergify bot mentioned this pull request Feb 22, 2024
Closed
@mergify mergify bot merged commit 790e4bd into main Feb 22, 2024
93 checks passed
@mergify mergify bot deleted the issue8199 branch February 22, 2024 12:41
@upbqdn upbqdn mentioned this pull request Feb 23, 2024
Merged
43 tasks
idky137 pushed a commit to idky137/zebra that referenced this pull request Feb 28, 2024
@oxarbitrage @idky137
update dry-run release commands (ZcashFoundation#8298)
b00b55d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@oxarbitrage oxarbitrage

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-release Area: Zebra releases and release management C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include new crates in release dry run workflow
2 participants
@oxarbitrage @upbqdn