Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): Set the full verify concurrency limit to 5 blocks #4758

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix(sync): Set the full verify concurrency limit to 5 blocks #4758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions zebrad/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,14 @@ impl Default for SyncSection {
// A few max-length checkpoints.
checkpoint_verify_concurrency_limit: sync::DEFAULT_CHECKPOINT_CONCURRENCY_LIMIT,

// Guaranteed to verify a bunch of large blocks in under 60 seconds
// (so that the committed block height changes in every progress log).
// This default is deliberately very low, so Zebra can verify a few large blocks in under 60 seconds,
// even on machines with only a few cores.
//
// TODO: when we implement orchard proof batching, try increasing to 100 or more
// This lets users see the committed block height changing in every progress log.
//
// TODO: when we implement orchard proof batching, try increasing to 20 or more
// limit full verification concurrency based on block transaction counts?
full_verify_concurrency_limit: 30,
full_verify_concurrency_limit: 5,
}
}
}