tests(rpc): add snapshot tests for rpc methods responses #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
May 8, 2022
upbqdn
previously approved these changes
May 11, 2022
3 tasks
* Create the snapshot settings once * Snapshot testnet state, RPCs, and transparent addresses * Tweak header comment * Ignore some duplicated dependencies we don't control
3 tasks
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
teor2345
approved these changes
May 16, 2022
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to lock the responses of the rpc methods so if anything change, tests will fail.
Close #4131
Solution
Add snapshots for each rpc method.
Review
@teor2345 introduced the snapshots and worked in most of them so it can be a good candidate, however anyone who had worked in this file before will find this tests easy to understand (with the addition of the snapshot).
Reviewer Checklist
Follow Up Work