Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): Fix some RPC response formats to match zcashd #4217

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Apr 27, 2022

Motivation

As part of #4130, I discovered some differences between Zebra and zcashd responses.

These are some of the minor ones that were easy to fix.

Specifications

https://zcash.github.io/rpc/getinfo.html
https://zcash.github.io/rpc/getaddressbalance.html
https://zcash.github.io/rpc/getrawmempool.html

Solution

  • Make the version number format match zcashd in getinfo
  • Remove an extra array wrapper in getaddressbalance
  • Return a stable sort order from getrawmempool
    • zcashd seems to return an arbitrary order here, so we might not be able to match it, and we probably shouldn't try

Review

Anyone can review this PR, it's not urgent.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@teor2345 teor2345 added C-bug Category: This is a bug P-Medium ⚡ A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels Apr 27, 2022
@teor2345 teor2345 requested a review from a team as a code owner April 27, 2022 05:49
@teor2345 teor2345 self-assigned this Apr 27, 2022
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team April 27, 2022 05:49
@teor2345 teor2345 changed the base branch from fix-rpc-content-type to main April 27, 2022 06:13
@teor2345 teor2345 changed the title fix(rpc): Fix RPC response formats to match zcashd fix(rpc): Fix some RPC response formats to match zcashd Apr 27, 2022
@teor2345 teor2345 requested a review from oxarbitrage April 27, 2022 21:33
@teor2345
Copy link
Contributor Author

@Mergifyio update

@teor2345
Copy link
Contributor Author

Some workflows seem to have hung on this PR, perhaps due to the GitHub automatic rebase.

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@teor2345
Copy link
Contributor Author

Temporary error:

error: failed to solve: failed to fetch oauth token: unexpected status: 401 Unauthorized
Error: buildx failed with: error: failed to solve: failed to fetch oauth token: unexpected status: 401 Unauthorized

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Apr 28, 2022
@mergify mergify bot merged commit 7506655 into main Apr 28, 2022
@mergify mergify bot deleted the minor-rpc-fixes branch April 28, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants