-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc): Fix some RPC response formats to match zcashd
#4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Because we can't match zcashd's arbitrary order, and probably shouldn't try to.
5cc84c8
to
cf80df6
Compare
zcashd
zcashd
oxarbitrage
reviewed
Apr 27, 2022
oxarbitrage
approved these changes
Apr 27, 2022
@Mergifyio update |
Some workflows seem to have hung on this PR, perhaps due to the GitHub automatic rebase. |
✅ Branch has been successfully updated |
@Mergifyio refresh |
Temporary error:
|
✅ Pull request refreshed |
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rpc
Area: Remote Procedure Call interfaces
C-bug
Category: This is a bug
lightwalletd
any work associated with lightwalletd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of #4130, I discovered some differences between Zebra and
zcashd
responses.These are some of the minor ones that were easy to fix.
Specifications
https://zcash.github.io/rpc/getinfo.html
https://zcash.github.io/rpc/getaddressbalance.html
https://zcash.github.io/rpc/getrawmempool.html
Solution
Review
Anyone can review this PR, it's not urgent.
Reviewer Checklist
Follow Up Work