fix(ci): do not delete instances from main
branch on merge
#4206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were never expecting the
ref
from apull_request
event would get mixed with the base branch at some point when using:The
closed
type pulls refs from thebase
branch instead of thePR
branch, causing this workflow to delete instances containingmain
in the name, instead of the PR name.Solution
ChangeGITHUB_REF_SLUG_URL
withGITHUB_HEAD_REF_SLUG_URL
to use the head branch from the PR instead of the PR ref, as (at this point) the PR is already merged.Delete the
clean.yml
workflowActually closes #3991, the previous PR #4198 didn't fix it, but it provided better diagnostics.
Review
@dconnolly or @teor2345 can review this
Follow Up Work
Later evaluate if automating instance deletion is required, and under which circumstances.