-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): implement the get_address_tx_ids RPC method query #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full validation sync failed due to #3991: |
feb498a
to
0824f83
Compare
45ec8b5
to
3c007fe
Compare
3c007fe
to
b2cf697
Compare
The first transaction's location is part of the address location.
32be7d8
to
9fc1490
Compare
oxarbitrage
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and it seems to work with the tests we have, additional tests will be added as part of other tickets. I think is ok to merge.
40 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rpc
Area: Remote Procedure Call interfaces
A-state
Area: State / database changes
C-enhancement
Category: This is an improvement
lightwalletd
any work associated with lightwalletd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a state query function and RPC method for the
get_address_tx_ids
RPC in ticket #3147.Specifications
RPC:
But only the arguments and fields in ticket #3147.
Designs
There are a few tricky parts of this PR:
We could try to hold a database read snapshot, but that could cause locking issues. Instead, I just retry a few times if the tx IDs might have changed. (If the query fails for this reason, Zebra is still syncing, and the results would probably be wrong anyway.)
But this is easier than the previous PR, because we can just combine the tx IDs, as long as there is chain overlap, or as long as we are querying a single address.
Solution
Add the get_address_tx_ids RPC method
Filter the tx IDs by the query height range
Retry interrupted finalized tx ID queries
Closes #3147.
Review
Anyone can review this PR, it's not urgent.
Reviewer Checklist
Follow Up Work
Do a bunch of RPC testing: