Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MEMPOOL_SIZE and just rely on the ZIP-401 cost limit #2962

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

conradoplg
Copy link
Collaborator

@conradoplg conradoplg commented Oct 27, 2021

Motivation

See #2958

Specifications

Designs

Solution

  • Remove MEMPOOL_SIZE
  • Fix tests, deriving a cost limit from a transaction count
  • Quote cost-limit rules

Closes #2958

Review

Probably @teor2345 and/or @dconnolly might want to review, but should be possible for anyone to review.

Branched from #2932, this must be merged after it (and this must be rebased after it merges)

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@dconnolly dconnolly linked an issue Oct 27, 2021 that may be closed by this pull request
@dconnolly dconnolly merged commit f157282 into limit-age-rejected-list Oct 27, 2021
@dconnolly dconnolly deleted the remove-mempool-size branch October 27, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MEMPOOL_SIZE and just rely on the ZIP-401 cost limit
2 participants