Avoid broadcasting mempool rejected or expired transactions to peers #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Oct 11, 2021
teor2345
reviewed
Oct 11, 2021
|
The linked issue is in the sprint, so this PR doesn't need to be in the sprint as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to avoid sending transactions to peers that were rejected or expired. Resolves #2846 if merged.
Solution
Broadcast only if the transaction returns
Okfrom theinsertmethod. Also remove transactions that are expired.Review
I think the intersection code can be simplified so i am looking for suggestions there. Also this code does not have a specific test.