Add expired transactions to the mempool rejected list #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
reviewed
Oct 8, 2021
dconnolly
reviewed
Oct 8, 2021
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
teor2345
reviewed
Oct 10, 2021
|
Please feel free to merge with or without these changes - no need to wait for my re-approval. I think this PR might conflict with ticket #2780, so we should try to get it merged on Monday. |
3 tasks
|
@conradoplg commit 51e59ae in PR #2855 resolves a tricky conflict between this PR and PR #2826. You might want to cherry-pick it here, after you review it. |
conradoplg
commented
Oct 11, 2021
There was a problem hiding this comment.
Addressed comments! @dconnolly can you take a look per @teor2345's comment?
teor2345
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a mempool transaction expires, we remove it from the mempool. But we should also add it to the rejected list, to avoid redownloading and reverifying it if it's sent again.
Specifications
Designs
Solution
chain_rejected_same_effectsinto two lists, to keep evicted and reject txs apart. (This was done by adding the lists to a HashMap, keyed by their respective error cases. This improved type safety a bit compared to just creating two separate lists)Closes #2848
Review
Anyone can review this.
Reviewer Checklist
Follow Up Work