Un-reject mempool transactions if the rejection depends on the current tip #2844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some mempool rejections only apply to the current tip, so we want to un-reject them whenever the tip changes.
We also want to make sure the rejection lists don't get too big.
Closes #2694.
Implements part of #2759 (some size limits).
Specifications
The mempool rejection rules aren't really specified anywhere.
We're re-using the size limit from ZIP-401 for all our reject lists:
https://zips.z.cash/zip-0401#specification
Solution
We might want to wait to add more tests until after PR #2821 or ZIP-401, because the APIs are still changing a lot.
Review
Anyone can review this PR, but I think @conradoplg wants it so he can complete PR #2821.
Reviewer Checklist