Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable port conflict related Windows tests #8553

Closed
oxarbitrage opened this issue May 18, 2024 · 0 comments · Fixed by #8624 or #8658
Closed

Re enable port conflict related Windows tests #8553

oxarbitrage opened this issue May 18, 2024 · 0 comments · Fixed by #8624 or #8658
Assignees
Labels
C-testing Category: These are tests P-High 🔥

Comments

@oxarbitrage
Copy link
Contributor

In #8551 we disabled some Windows tests that were failing with port conflicts to often.

Possible design:

Use OS assigned ports whenever binding a TcpListener and get the socket address directly from the TcpListener:

  • Return the listen address from open_listener() in the peer set init() function and use it instead of the random known port
  • Use the address() method on Server in zebra-rpc (server_instance.address())
  • Bind a TcpListener in zebra-grpc, return the address (maybe via a oneshot channel? Or by spawning a tokio task and returning the value from the init function) and replace the call to Router.serve() with serve_with_incoming()
  • Use port 0 for the RPC listen addr and read the RPC socket address from the Zebra's logs when spawning TestChilds instead of using the config value
@github-project-automation github-project-automation bot moved this to New in Zebra May 18, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Jun 3, 2024
@arya2 arya2 self-assigned this Jun 10, 2024
@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in Zebra Jun 17, 2024
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in Zebra Jun 17, 2024
@arya2 arya2 self-assigned this Jun 17, 2024
@arya2 arya2 moved this from Sprint Backlog to In progress in Zebra Jun 17, 2024
@arya2 arya2 added C-testing Category: These are tests P-High 🔥 labels Jun 17, 2024
@mpguerra mpguerra moved this from In progress to Review/QA in Zebra Jun 20, 2024
@mergify mergify bot closed this as completed in #8624 Jun 21, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests P-High 🔥
Projects
Archived in project
2 participants