Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the consensus branch ID and activation heights to the consensus parameters #716

Closed
2 of 3 tasks
teor2345 opened this issue Jul 22, 2020 · 0 comments · Fixed by #722
Closed
2 of 3 tasks

Add the consensus branch ID and activation heights to the consensus parameters #716

teor2345 opened this issue Jul 22, 2020 · 0 comments · Fixed by #722
Assignees
@teor2345
Labels
A-consensus Area: Consensus rule updates
Milestone
Block Validation

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 22, 2020 •
edited
Loading

PR #699 adds a NetworkUpgrade enum and associated protocol versions.

After it merges, we should also add:

  • the consensus branch ID, and
  • the network upgrade activation heights (for Mainnet and Testnet).
  • dynamic network protocol versions based on the current block height - requires passing network and height to the peer module

We need the consensus branch ID to validate scripts.
@teor2345 teor2345 added Poll::Ready A-consensus Area: Consensus rule updates S-blocked Status: Blocked on other tasks labels Jul 22, 2020
@teor2345 teor2345 self-assigned this Jul 22, 2020
This was referenced Jul 22, 2020
Closed
Closed
@teor2345 teor2345 mentioned this issue Jul 23, 2020
Merged
3 tasks
@dconnolly dconnolly mentioned this issue Aug 11, 2020
Closed
27 tasks
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-consensus Area: Consensus rule updates
Projects
None yet
Milestone
Block Validation
Development

Successfully merging a pull request may close this issue.

Add Network Upgrade Heights and Branch IDs teor2345/zebra
2 participants
@mpguerra @teor2345