Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Upgrade shared ECC dependencies and zcash_script for zcashd 5.6.0 #6859

Closed
8 tasks done
teor2345 opened this issue Jun 7, 2023 · 7 comments · Fixed by #7053
Closed
8 tasks done

Tracking: Upgrade shared ECC dependencies and zcash_script for zcashd 5.6.0 #6859

teor2345 opened this issue Jun 7, 2023 · 7 comments · Fixed by #7053
Assignees
Labels
A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jun 7, 2023

Motivation

We need to do a routine update to our shared ECC dependencies in Zebra:

These should be done together to avoid duplicate dependencies.
We might want to do incrementalmerkletree in a separate PR because it has breaking API changes.

Testing

Our existing tests cover these crates, except for the note commitment tree serialisation format in RPCs. That will need a test, ideally a snapshot test that is written based on the format before the upgrade.

Related Work

This probably needs to happen before the RPC changes, but after the first stable release.

@mpguerra
Copy link
Contributor

mpguerra commented Jun 15, 2023

Part of this ticket is blocked by the zcashd 5.6.0 release

I see it's already been released 😅

@mpguerra
Copy link
Contributor

@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Jun 15, 2023
@teor2345
Copy link
Contributor Author

Estimation note: there are some API changes in incrementalmerkletree, see PR #6836 and maybe ticket #6642 for details.

@dconnolly
Copy link
Contributor

@oxarbitrage for upgrading incrementalmerkletree, here's a summary of the changes I spotted as we upgrade to 0.4.0

#6836 (comment)

@arya2 arya2 self-assigned this Jun 26, 2023
@mpguerra mpguerra changed the title Upgrade shared ECC dependencies and zcash_script for zcashd 5.6.0 Tracking: Upgrade shared ECC dependencies and zcash_script for zcashd 5.6.0 Jun 27, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Jun 29, 2023

zcash_proofs updated to 0.12.1 (#7107)

@mpguerra
Copy link
Contributor

@oxarbitrage do you want to update this estimate? :D

@oxarbitrage
Copy link
Contributor

@oxarbitrage do you want to update this estimate? :D

Changed to 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage
Projects
Archived in project
5 participants