Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getaddressutxos RPC is missing non-finalized UTXOs #4220

Closed
teor2345 opened this issue Apr 27, 2022 · 0 comments · Fixed by #4356
Closed

getaddressutxos RPC is missing non-finalized UTXOs #4220

teor2345 opened this issue Apr 27, 2022 · 0 comments · Fixed by #4356
Assignees
@teor2345
Labels
A-rpc Area: Remote Procedure Call interfaces A-state Area: State / database changes C-bug Category: This is a bug lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

teor2345 commented Apr 27, 2022 •
edited
Loading

Motivation

When I compare zebrad and zcashd RPC responses for getaddressutxos, using this command:

zebra-utils/zcash-rpc-diff 28232 getaddressutxos '{ "addresses": ["t3dvVE3SQEi7kqNzwrfNePxZ1d4hUyztBA1"] }'

The last 100 UTXOs are missing. This looks like all the non-finalized UTXOs.

Steps to Diagnose

Check these parts of the address UTXOs code:

  • the non-finalized state query
  • the code that skips the non-finalized state query
  • the function that combines both sets of UTXOs
@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-Medium ⚡ A-rpc Area: Remote Procedure Call interfaces A-state Area: State / database changes lightwalletd any work associated with lightwalletd labels Apr 27, 2022
@teor2345 teor2345 mentioned this issue Apr 27, 2022
Closed
@teor2345 teor2345 self-assigned this Apr 28, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label May 6, 2022
@teor2345 teor2345 mentioned this issue May 9, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #4356 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-rpc Area: Remote Procedure Call interfaces A-state Area: State / database changes C-bug Category: This is a bug lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(state): return non-finalized UTXOs and tx IDs in address queries ZcashFoundation/zebra
2 participants
@teor2345 @ftm1000