Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getaddresstxids RPC should have a single struct argument, not multiple arguments #4216

Closed
teor2345 opened this issue Apr 27, 2022 · 0 comments · Fixed by #4264
Closed

getaddresstxids RPC should have a single struct argument, not multiple arguments #4216

teor2345 opened this issue Apr 27, 2022 · 0 comments · Fixed by #4264
Assignees
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

teor2345 commented Apr 27, 2022

Motivation

When I run this command against zcashd it works:

zcash-cli getaddresstxids '{"addresses": ["t3LmX1cxWPPPqL4TZHx42HU3U5ghbFjRiif"], "start": 1000, "end": 2000}'

But when I run it against Zebra, it fails:

zcash-cli -rpcport="$ZEBRAD_RPC_PORT" '{"addresses": ["t3LmX1cxWPPPqL4TZHx42HU3U5ghbFjRiif"], "start": 1000, "end": 2000}'

With this error:

error code: -32602
error message:
Invalid params: invalid length 1, expected a tuple of size 3.

This check needs the fix in PR #4215.

Designs

It looks like Zebra should take a single struct argument with named fields, rather than multiple named arguments.

This appears to be the only lightwalletd request with multiple named fields:
https://github.com/zcash/lightwalletd/blob/bdaac63f3ee0dbef62bde04f6817a9f90d483b00/common/common.go#L97

@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-Medium ⚡ A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels Apr 27, 2022
@oxarbitrage oxarbitrage self-assigned this Apr 29, 2022
@mergify mergify bot closed this as completed in #4264 May 5, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants