Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC response snapshot tests #4131

Closed
teor2345 opened this issue Apr 18, 2022 · 0 comments · Fixed by #4352
Closed

Add RPC response snapshot tests #4131

teor2345 opened this issue Apr 18, 2022 · 0 comments · Fixed by #4352
Assignees
Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

teor2345 commented Apr 18, 2022

Motivation

In the address index review meeting last week, we talked about testing address indexes.

One of the ways we can test is by checking that Zebra's RPC responses match a snapshot of a previous response. If the changes are intentional, we can update the snapshot. If they aren't, we can fix the PR.

These snapshots also help us make sure that differences between Zebra and zcashd stay fixed (#4130).

Designs

We can test RPCs by:

  • adding some blocks to a Zebra state
  • sending an RPC query
  • snapshotting the response using cargo insta

We already have similar tests for the Zebra state database.

Related Work

@teor2345 teor2345 added S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels Apr 18, 2022
@oxarbitrage oxarbitrage self-assigned this May 4, 2022
@mergify mergify bot closed this as completed in #4352 May 16, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants