Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop re-checking the same Google Cloud log line in a loop #4080

Closed
teor2345 opened this issue Apr 10, 2022 · 0 comments · Fixed by #4252
Closed

ci: stop re-checking the same Google Cloud log line in a loop #4080

teor2345 opened this issue Apr 10, 2022 · 0 comments · Fixed by #4252
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-hang A Zebra component stops responding to requests

Comments

@teor2345
Copy link
Contributor

Motivation

In some workflows, we re-check the same Google Cloud log line multiple times in a loop:

while [[ ${SYNC_HEIGHT} == "" ]]; do
SYNC_HEIGHT=$(gcloud logging read --format='value(jsonPayload.MESSAGE)' --order="desc" --limit=1 '(resource.labels.instance_id="${{ env.INSTANCE_ID }}" AND jsonPayload.message=~".+finished initial sync to chain tip.+Height\([0-9]+\).+")' | grep -oE 'Height\([0-9]+\)' | grep -oE '[0-9]+' || [[ $? == 1 ]] )
echo "SYNC_HEIGHT: $SYNC_HEIGHT"
sleep 10
done

This log line will never change, because the zebrad process has finished.

This could cause hangs, but it doesn't seem to be doing that right now, so it's a low priority.

Designs

In every workflow that checks logs after zebrad has exited:

  • Just check the log lines once
  • If that causes failures, go back further in the logs
@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles S-needs-triage Status: A bug report needs triage P-Low ❄️ I-hang A Zebra component stops responding to requests labels Apr 10, 2022
@gustavovalverde gustavovalverde self-assigned this Apr 11, 2022
@mergify mergify bot closed this as completed in #4252 May 3, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-hang A Zebra component stops responding to requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants