Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all mpsc channels use tokio::sync::mpsc #3260

Closed
teor2345 opened this issue Dec 20, 2021 · 1 comment
Closed

Make all mpsc channels use tokio::sync::mpsc #3260

teor2345 opened this issue Dec 20, 2021 · 1 comment
Labels
A-network Area: Network protocol updates or fixes C-cleanup Category: This is a cleanup

Comments

@teor2345
Copy link
Contributor

Motivation

In PR #3244, we changed some mpsc channels to use tokio::sync::mpsc, because we needed a non-async receiver method.

But some channels were left on futures::channel::mpsc, because they have an automatic Stream impl.

Suggested Solution

  • Replace futures::channel::mpsc with tokio::sync::mpsc
  • Use ReceiverStream where needed
  • Fix up the error handling and error types
@teor2345 teor2345 added C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Optional A-network Area: Network protocol updates or fixes labels Dec 20, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 1, 2022

I'm not sure this cleanup is actually possible, due to API differences.

@teor2345 teor2345 closed this as completed Mar 1, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-cleanup Category: This is a cleanup
Projects
None yet
Development

No branches or pull requests

2 participants