Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expired transactions to the mempool rejected list #2848

Closed
conradoplg opened this issue Oct 7, 2021 · 0 comments · Fixed by #2852
Closed

Add expired transactions to the mempool rejected list #2848

conradoplg opened this issue Oct 7, 2021 · 0 comments · Fixed by #2852
Assignees
Labels
C-enhancement Category: This is an improvement

Comments

@conradoplg
Copy link
Collaborator

Motivation

When a mempool transaction expires, we remove it from the mempool. But we should also add it to the rejected list, to avoid redownloading and reverifying it if it's sent again.

Specifications

Designs

At first the tx would fit into the chain_rejected_same_effects list which is used by txs rejected by excess capacity. But we should create a separate list for expired transactions. See discussion

Related Work

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Low labels Oct 7, 2021
@teor2345 teor2345 added this to the 2021 Sprint 20 milestone Oct 7, 2021
@conradoplg conradoplg self-assigned this Oct 8, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants