Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that finalized state UTXOs are present before deleting them #2518

Closed
teor2345 opened this issue Jul 22, 2021 · 0 comments · Fixed by #2599
Closed

Check that finalized state UTXOs are present before deleting them #2518

teor2345 opened this issue Jul 22, 2021 · 0 comments · Fixed by #2599
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-bug Category: This is a bug NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter)

Comments

@teor2345
Copy link
Contributor

Motivation

We're currently deleting UTXOs using a RocksDB method directly.

But we want to check if they exist first - because deleting a UTXO that doesn't exist is a bug.

Related Work

This change depends on PR #2458.
@teor2345 teor2345 added C-bug Category: This is a bug A-consensus Area: Consensus rule updates NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage P-Low labels Jul 22, 2021
@teor2345 teor2345 mentioned this issue Jul 22, 2021
Merged
3 tasks
@teor2345 teor2345 changed the title Delete finalized state UTXOs using zs_delete Check that finalized state UTXOs are present before deleting them Jul 26, 2021
@teor2345 teor2345 mentioned this issue Aug 13, 2021
Merged
3 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-bug Category: This is a bug NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add value pools to FinalizedState oxarbitrage/zebra
2 participants
@mpguerra @teor2345