Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: stop panicking due to NU5 unimplemented!() statements #2369

Closed
3 tasks
teor2345 opened this issue Jun 22, 2021 · 1 comment · Fixed by #2471
Closed
3 tasks

Security: stop panicking due to NU5 unimplemented!() statements #2369

teor2345 opened this issue Jun 22, 2021 · 1 comment · Fixed by #2471
Assignees
@jvff
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-security Category: Security issues I-panic Zebra panics with an internal error message NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 13

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jun 22, 2021 •
edited
Loading

Motivation

When we were adding NU5 support to Zebra, we added comment TODOs and unimplemented!() placeholders to Zebra.

We need to make sure all the unimplemented!() placeholders have been removed. We should also check for any comment TODOs.

This ticket needs to be completed before NU5 testnet activation, otherwise Zebra will panic as soon as NU5 activates.

Solution

Fixing panics:

  • Turn unimplemented!() statements that haven't been implemented into tickets
  • Remove unimplemented!() statements that have been implemented elsewhere

Task tracking (lower priority):

  • Check for NU5 or ZIP TODO comments, and make sure they have tickets
@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium C-security Category: Security issues I-panic Zebra panics with an internal error message labels Jun 22, 2021
@teor2345 teor2345 added this to the 2021 Sprint 14 milestone Jun 22, 2021
@teor2345
Copy link
Contributor Author

@mpguerra this ticket needs to be completed before NU5 testnet activation, otherwise Zebra will panic as soon as NU5 activates.

@teor2345 teor2345 changed the title Remove NU5 unimplemented!() statements to avoid panics Security: stop panicking due to NU5 unimplemented!() statements Jun 23, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 25, 2021
@teor2345 teor2345 self-assigned this Jun 29, 2021
@jvff jvff self-assigned this Jul 7, 2021
@jvff jvff mentioned this issue Jul 8, 2021
Closed
@teor2345 teor2345 mentioned this issue Jul 9, 2021
Merged
3 tasks
@mpguerra mpguerra reopened this Jul 9, 2021
@mpguerra mpguerra closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvff jvff

Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-security Category: Security issues I-panic Zebra panics with an internal error message NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 13
Development

Successfully merging a pull request may close this issue.

Update panics by todo! and unimplemented! macros jvff/zebra
3 participants
@mpguerra @jvff @teor2345