Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for ZIP-213: Validate Shielded Coinbase Outputs #2115

Closed
mpguerra opened this issue May 6, 2021 · 2 comments
Closed

RFC for ZIP-213: Validate Shielded Coinbase Outputs #2115

mpguerra opened this issue May 6, 2021 · 2 comments
Labels
C-enhancement Category: This is an improvement NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-4 Canopy Network Upgrade: Canopy specific tasks NU-5 Network Upgrade: NU5 specific tasks

Comments

@mpguerra
Copy link
Contributor

mpguerra commented May 6, 2021

Is your feature request related to a problem? Please describe.

ZIP-213 introduces shielded coinbase.

Describe the solution you'd like
In order to implement this we should first write up the design for how this work in an RFC.

Additional context

PR #1190 started implementing this work and should be used to inform the design and write up

@mpguerra mpguerra added NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-4 Canopy Network Upgrade: Canopy specific tasks C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks labels May 6, 2021
@mpguerra mpguerra added this to the 2021 Sprint 11 - Zcon2 milestone May 6, 2021
@mpguerra mpguerra added P-Medium and removed S-needs-triage Status: A bug report needs triage labels May 7, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 13 milestone Jun 16, 2021
@mpguerra
Copy link
Contributor Author

Moving this out of Sprint 13 as we'll deal with coinbase rules at a later date, post NU5 activation

@teor2345 teor2345 changed the title RFC for ZIP-213: Shielded Coinbase rules for Heartwood RFC for ZIP-213: Validate Shielded Coinbase Outputs Jun 17, 2021
@teor2345
Copy link
Contributor

Moving this out of Sprint 13 as we'll deal with coinbase rules at a later date, post NU5 activation

We're only skipping coinbase input validation: Founders Reward, Funding Streams, and Miner Rewards.
We have to validate coinbase outputs, because outputs get spent along with other Zcash coins.

But looking at the list of consensus rules in #608, we don't need a design here, just some good function and module docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-4 Canopy Network Upgrade: Canopy specific tasks NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

No branches or pull requests

2 participants