Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send inbound PushTransactions broadcasts to the mempool download and verify stream #1080

Closed
hdevalence opened this issue Sep 20, 2020 · 3 comments
Closed

Send inbound PushTransactions broadcasts to the mempool download and verify stream #1080

hdevalence opened this issue Sep 20, 2020 · 3 comments
Assignees
@oxarbitrage
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Sep 20, 2020 •
edited by teor2345
Loading

Is your feature request related to a problem? Please describe.

The inbound network service should handle PushTransaction requests correctly.

This implements handling an unsolicited tx message from a remote peer, when a transaction is added to that peer's mempool.

Describe the solution you'd like

Send transactions from PushTransaction to the mempool download and verify service.

Additional context

Part of #889.
@hdevalence hdevalence added A-rust Area: Updates to Rust code S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement labels Sep 20, 2020
@hdevalence hdevalence mentioned this issue Sep 20, 2020
Closed
11 tasks
@teor2345 teor2345 added this to the Sync and Network milestone Sep 29, 2020
@mpguerra mpguerra removed this from the Sync and Network milestone Jan 5, 2021
@mpguerra mpguerra added this to the 2021 Sprint 16 milestone Aug 9, 2021
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Aug 9, 2021
@dconnolly dconnolly removed this from the 2021 Sprint 16 milestone Aug 9, 2021
@mpguerra mpguerra mentioned this issue Aug 11, 2021
Closed
59 tasks
@mpguerra mpguerra changed the title Handle PushTransaction in the Inbound service. Handle outgoing tx messages in PushTransaction in the Inbound service. Aug 11, 2021
@teor2345 teor2345 changed the title Handle outgoing tx messages in PushTransaction in the Inbound service. Handle inbound tx messages in PushTransaction in the Inbound service Aug 17, 2021
@teor2345
Copy link
Contributor

I've clarified this ticket to focus on inbound transactions from peer mempools

@teor2345 teor2345 changed the title Handle inbound tx messages in PushTransaction in the Inbound service Send inbound PushTransactions to the mempool download and verify service Aug 17, 2021
@teor2345 teor2345 changed the title Send inbound PushTransactions to the mempool download and verify service Send inbound PushTransactions to the mempool download and verify stream Aug 17, 2021
@teor2345 teor2345 changed the title Send inbound PushTransactions to the mempool download and verify stream Send inbound PushTransactions broadcasts to the mempool download and verify stream Aug 17, 2021
@mpguerra mpguerra added this to the 2021 Sprint 18 milestone Aug 26, 2021
@conradoplg
Copy link
Collaborator

This may be the same as #2692 ?

@oxarbitrage
Copy link
Contributor

Closed by #2727

@mpguerra mpguerra removed this from the 2021 Sprint 18 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@conradoplg @hdevalence @dconnolly @mpguerra @teor2345 @oxarbitrage