From 3693b96ed4f4339dddf15bd2046fbc39f1838bca Mon Sep 17 00:00:00 2001 From: Taylor Hornby Date: Thu, 30 Apr 2020 16:02:01 -0600 Subject: [PATCH] Fix undefined behavior in the test_bitcoin tests --- src/consensus/params.h | 2 +- src/wallet/test/rpc_wallet_tests.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/consensus/params.h b/src/consensus/params.h index 1d637235b..48419136b 100644 --- a/src/consensus/params.h +++ b/src/consensus/params.h @@ -168,7 +168,7 @@ struct Params { uint256 hashGenesisBlock; - bool fCoinbaseMustBeShielded; + bool fCoinbaseMustBeShielded = false; /** Needs to evenly divide MAX_SUBSIDY to avoid rounding errors. */ int nSubsidySlowStartInterval; diff --git a/src/wallet/test/rpc_wallet_tests.cpp b/src/wallet/test/rpc_wallet_tests.cpp index 208d803a0..64f953412 100644 --- a/src/wallet/test/rpc_wallet_tests.cpp +++ b/src/wallet/test/rpc_wallet_tests.cpp @@ -2021,7 +2021,7 @@ BOOST_AUTO_TEST_CASE(rpc_z_mergetoaddress_internals) TEST_FRIEND_AsyncRPCOperation_mergetoaddress proxy(ptr); // Enable test mode so tx is not sent and proofs are not generated - static_cast(operation.get())->testmode = true; + static_cast(operation.get())->testmode = true; MergeToAddressJSInfo info; std::vector> witnesses;