Fix undefined behavior in the test_bitcoin tests

ZcashFoundation · Oct 1, 2020 · 3693b96 · 3693b96
1 parent 939c5df
commit 3693b96
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/consensus/params.h b/src/consensus/params.h
@@ -168,7 +168,7 @@ struct Params {
 
     uint256 hashGenesisBlock;
 
-    bool fCoinbaseMustBeShielded;
+    bool fCoinbaseMustBeShielded = false;
 
     /** Needs to evenly divide MAX_SUBSIDY to avoid rounding errors. */
     int nSubsidySlowStartInterval;

diff --git a/src/wallet/test/rpc_wallet_tests.cpp b/src/wallet/test/rpc_wallet_tests.cpp
@@ -2021,7 +2021,7 @@ BOOST_AUTO_TEST_CASE(rpc_z_mergetoaddress_internals)
         TEST_FRIEND_AsyncRPCOperation_mergetoaddress proxy(ptr);
 
         // Enable test mode so tx is not sent and proofs are not generated
-        static_cast<AsyncRPCOperation_sendmany *>(operation.get())->testmode = true;
+        static_cast<AsyncRPCOperation_mergetoaddress *>(operation.get())->testmode = true;
 
         MergeToAddressJSInfo info;
         std::vector<boost::optional < SproutWitness>> witnesses;