Skip peers using non-std ports before adding to queue #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17 we avoided connecting to peers using flux ports. However the crawl was too slow (~13 hours?). I added the skip logic to when the addresses are returned by peers, before adding them to the queue, which makes crawling much faster (~5 min). (Not totally sure why. Are Go channels that slow? 🤔 )
I tried block those addresses, but thinking about it, it does not seem to be the correct approach, since zcashd nodes can still conect to flux peers (i.e. just because a peer return peers using flux ports, it does not mean that peer is bad).