Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show information message on users with active blocks, hinting to contact DWG instead #18

Open
mmd-osm opened this issue Oct 25, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@mmd-osm
Copy link

mmd-osm commented Oct 25, 2023

I've noticed that some of the nodes that have been reverted in https://www.openstreetmap.org/changeset/143128522 seem to be lacking their tags from previous versions.

Example: https://www.openstreetmap.org/node/540424027/history

I would expect a website tag in version 19, which was present in version 13 or 15. Both of which I would consider as a good versions. The full history also shows that all versions have different timestamps, so the infamous Overpass issue with multiple versions at the same time shouldn't apply here.

@Zaczero
Copy link
Owner

Zaczero commented Oct 25, 2023

image

https://osm.mapki.com/history/node/540424027

Please take note of the changeset ID that has been reverted (143124536). This revert tool automatically resolves conflicts in tags, relations, etc.. To restore the original set of tags, the changeset IDs 143124619 and 143124645 should also be reverted.

@mmd-osm
Copy link
Author

mmd-osm commented Oct 25, 2023

Thank you for your quick and detailed analysis. So when I get this right, the idea is to compensate the changes which have been done between versions 15 and 16 as part of cs 143124536, and apply the result on 18?

It seems people are having a bit of a hard time to figure out, that vandals upload multiple versions of the same objects, and that some kind of transitive closure of these changes would be needed to do a full revert. I'm not sure if this is in scope of Thanos?

@Zaczero
Copy link
Owner

Zaczero commented Oct 25, 2023

Yes, this is within the scope of Thanos (full revert + revert to a specific version). In many cases, individuals revert certain changesets without realizing the full extent of the issue. I'm considering adding an informational notice to the page. Do you have any suggestions for what it should say?

@mmd-osm
Copy link
Author

mmd-osm commented Oct 25, 2023

DWG folks are probably in a better position to suggest a meaningful text here, since they're most impacted by partial reverts.

However, maybe you could check, if the changeset to be reverted has been created by a user with an active block, and show some hint to align with the DWG first, or even don't let users perform the revert at all. DWG probably has an opinion on this topic. I would again recommend to reach out to them.

In the particular case I have mentioned in this issue, https://www.openstreetmap.org/user_blocks/15267 was created a few minutes after the malicious upload, while the revert attempt happened only two hours later.

@Zaczero Zaczero added the enhancement New feature or request label Dec 1, 2023
@Zaczero Zaczero changed the title Missing tags? Show information message on users with active blocks, hinting to contact DWG instead Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants