Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gifs duplication issue when long pressing #67

Closed
Tunous opened this issue Oct 20, 2017 · 7 comments
Closed

Gifs duplication issue when long pressing #67

Tunous opened this issue Oct 20, 2017 · 7 comments
Labels

Comments

@Tunous
Copy link

Tunous commented Oct 20, 2017

When long pressing on multiple gifs (one after another) the newly selected gif is copied to the position of previous as seen here:

preview

Running on Android 7.1

@ZacSweers
Copy link
Owner

Yeah I've seen that before as well but not sure what causes it. Will take a look at the Plaid code to see if I'm missing something

@charlesdurham
Copy link
Contributor

charlesdurham commented Oct 29, 2017

Seems like it might have something to do with Glide's bitmap caching, this hack fixes the issue:

 Glide.get(context).bitmapPool.setSizeMultiplier(0f)

I also checked out Plaid and saw the same issue.

@ZacSweers
Copy link
Owner

Interesting... do you know what about that workaround fixes it? I'm not familiar with the setSizeMultiplier method, or really bitmapPools in general. CC @nickbutcher

@charlesdurham
Copy link
Contributor

It makes the bitmap pool size 0 so no bitmaps will get reused (there may be a cleaner way of doing this in glide lol). Either way, it's not a viable solution, I was just using it to test my hunch.

@ZacSweers
Copy link
Owner

OH, lol yeah interesting, wonder if it's worth reporting to Glide. I'll dig through their issue tracker for something related before I do

@charlesdurham
Copy link
Contributor

I didn't find anything in their backlog, but there's a lot there so I could have missed something. I'll probably try to grab a simple repro case and log an issue (unless you find one in their backlog).

@charlesdurham
Copy link
Contributor

bumptech/glide#2526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants